Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin setuptools version to 73.0.1 #298

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

vpung
Copy link
Contributor

@vpung vpung commented Aug 27, 2024

Issue #, if available: N/A

Description of changes:
Pin the version of setuptools to be 73.0.1. The latest version of setuptools is 74.0.0 and Github workflow fails with message:

ModuleNotFoundError: No module named 'distutils.msvccompiler'

According to the release notes of setuptools, distutils has been deprecated. Reading from the Numpy docs, distutils also is marked as deprecated. The solution provided is to temporarily pin down the version of setuptools to the last known working version of our build which is version 73.0.1.

Testing the pin down version of setuptools, we get the following error: ERROR: Some build dependencies for file:///home/ec2-user/pecos conflict with the backend dependencies: setuptools==74.0.0 is incompatible with setuptools<=73.0.1. We pin down pip to the highest version possible without getting this error which is pip==23.0.1.

Pinning down setuptools and pip is temporary and the following weeks, we should move away from distutils and revert these changes.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@vpung vpung force-pushed the pin-setuptools branch 2 times, most recently from 48170b9 to 9821bcf Compare August 27, 2024 22:33
@weiliw-amz
Copy link
Contributor

Could you provide references links for ongoing issue that new release of setuptools==74.0.0 breaks numpy installation, so as a dependency, we have to pin down to old version until a fix is made?

Also, we need a TODO tag and comments for reason around these temp fixing lines for reminder.

@vpung vpung force-pushed the pin-setuptools branch 2 times, most recently from 9092d1d to 8ee387b Compare August 28, 2024 21:06
@vpung vpung requested a review from weiliw-amz August 28, 2024 22:32
@vpung vpung self-assigned this Aug 28, 2024
@vpung vpung added the dependencies Pull requests that update a dependency file label Aug 28, 2024
@vpung vpung marked this pull request as ready for review August 28, 2024 22:33
@vpung vpung merged commit 455db26 into amzn:mainline Aug 28, 2024
25 checks passed
@vpung vpung deleted the pin-setuptools branch August 28, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants