Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update mssql extractor to utilize proper case for case sensitive MSSQL databases #2234

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ardcarmvk
Copy link

Correct SQL code's table and column case so mssql extractor works with case sensitive instances

Description

Some SQL Server databases are configured as case sensitive. Changes were made for utilizing proper case in
required areas.

Motivation and Context

Extractor will not work on mssql databases that are case sensitive

How Has This Been Tested?

Ran the SQL code on SQL database with case sensitivity, tested the extractor against non-case sensitive and case sensitive
databases. Ran on windows 10 with python 3.12 on local machine.

Documentation

CheckList

  • [ x ] PR title addresses the issue accurately and concisely
  • [ x ] Updates Documentation and Docstrings
  • Adds tests
  • Adds instrumentation (logs, or UI events)

Correct case so mssql extractor works with case sensitive instances
@ardcarmvk ardcarmvk requested a review from a team as a code owner February 26, 2024 23:09
@boring-cyborg boring-cyborg bot added the area:databuilder From databuilder folder label Feb 26, 2024
Copy link

boring-cyborg bot commented Feb 26, 2024

Congratulations on your first Pull Request and welcome to Amundsen community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/amundsen-io/amundsen/blob/main/CONTRIBUTING.md)

innocuous change to add signed off.
Signed-off-by: Andrew Neuer <[email protected]>
@Golodhros
Copy link
Member

Please check the DCO task above

@ardcarmvk
Copy link
Author

DCO task should be resolved now, just need review. Thanks

@Golodhros
Copy link
Member

@ardcarmvk it seems it got broken again

@kristenarmes
Copy link
Contributor

@ardcarmvk it seems it got broken again

I think the issue is the original commit has to be modified to include the sign off, check out the details in the failed task here for instructions

Copy link

stale bot commented Apr 22, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:databuilder From databuilder folder stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants