Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: preview environments for every PR using Uffizzi #2051

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

waveywaves
Copy link

@waveywaves waveywaves commented Dec 8, 2022

Summary of Changes

Add github workflow which builds the amundsend metadata, search and frontend images from the PR branch and uses them to create a preview environment on Uffizzi.

A PoC of this PR has been done here
After this PR is merged, all the subsequent PRs to this repo will have preview environments deployed with a link to the preview posted to the PR like this
The preview created in the above PR can be accessed here https://app.uffizzi.com/github.com/waveywaves/amundsen/pull/1

fixes #2040

Tests

Documentation

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

@waveywaves waveywaves requested a review from a team as a code owner December 8, 2022 21:20
@boring-cyborg boring-cyborg bot added the area:all Related to all the project label Dec 8, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Dec 8, 2022

Congratulations on your first Pull Request and welcome to Amundsen community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/amundsen-io/amundsen/blob/main/CONTRIBUTING.md)

@waveywaves
Copy link
Author

cc @Golodhros

@Golodhros
Copy link
Member

What do you think of this @feng-tao and @verdan ?

It works, although we should tweak our docker stuff to have some test data in order for it to be useful

@kristenarmes
Copy link
Contributor

Hi @waveywaves, thank you for integrating this! In terms of the question of test data, I know the Quick Start steps outline how to include some sample data - would it be possible to include the same here?

@feng-tao
Copy link
Member

feng-tao commented Dec 10, 2022

I don't have any context on the use case or the product. So need to defer to others to review

@Golodhros
Copy link
Member

I don't have any context on the use case or the product. So need to defer to others to review

This allows us to have a private URL where we see the changes introduced by a PR in real live!

@waveywaves
Copy link
Author

This allows us to have a private URL where we see the changes introduced by a PR in real live!

@Golodhros It will be a public URL :)
You can show off your new features in team meetings and also share the preview with customers who would want a certain feature/bug, implemented/fixed.

Signed-off-by: Vibhav Bobade <[email protected]>
@waveywaves
Copy link
Author

@kristenarmes Thank you for the tip. I have created a dockerfile which will help us build the databuilder-init image which we can use to initialize the db with some data. Although, I am facing a problem during it's build. Getting a Could not import runpy module during it's build. Here is the build for context.

@stale
Copy link

stale bot commented Dec 31, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Dec 31, 2022
@waveywaves
Copy link
Author

waveywaves commented Jan 3, 2023

Happy New year team ! @Golodhros let me know if these changes make sense. And let me know if this works for you.

#2051 (comment) how can I solve this problem

@Golodhros Golodhros added keep fresh Disables stalebot from closing an issue and removed stale labels Jan 3, 2023
@jpthurman
Copy link

Hi @Golodhros - friendly ping. I discussed this with @waveywaves and just wanted to check in and see if Preview Environments for every PR is something you want. If not we can close out the PR

@Golodhros
Copy link
Member

Hi @Golodhros - friendly ping. I discussed this with @waveywaves and just wanted to check in and see if Preview Environments for every PR is something you want. If not we can close out the PR

Hi @jpthurman, this is definitely something we want to have!

The problem is that the team at Lyft is really busy these days and I don't have the skills to help you solve that issue. I will keep on pinging other maintainers to see if they can help!

Thanks for your patience!

@jpthurman
Copy link

Thanks for the reply @Golodhros

I think this can be solved in a short zoom call. Can you set up a time with right person within Lyft?
Cc @waveywaves

@Golodhros
Copy link
Member

Thanks for the reply @Golodhros

I think this can be solved in a short zoom call. Can you set up a time with right person within Lyft? Cc @waveywaves

Makes sense!
Give me some days to figure it out though, we have an upcoming internal presentation that the team is focused on these days!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:all Related to all the project keep fresh Disables stalebot from closing an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pull Request Preview Environments for increasing maintainer productivity
5 participants