Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft]: Feat: granular access control Pre-RFC demo #2029

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

xfiderek
Copy link
Contributor

@xfiderek xfiderek commented Nov 12, 2022

Summary of Changes

This is a draft PR with demo of proposed granular access control model for amundsen.
*For more details, please refer to the following slack message
As soon as concept is approved on slack, I will fix formatting and code coverage - please treat this PR as a demo

Tests

Currently only metadata endpoint is tested, as it was only endpoint modified. Classes are not tested yet. After initial approval of the concept, other tests will be implemented

Documentation

There is almost no documentation - refer to slack message linked above

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

@xfiderek xfiderek requested a review from a team as a code owner November 12, 2022 15:01
@boring-cyborg boring-cyborg bot added area:frontend From the Frontend folder category:api labels Nov 12, 2022
@xfiderek xfiderek changed the title Feat/accesscontrol [Draft]: Feat: granular access control Pre-RFC demo Nov 12, 2022
@feng-tao feng-tao added the keep fresh Disables stalebot from closing an issue label Nov 18, 2022
@Golodhros Golodhros added rfc Indicates that there is an RFC associated with this issue. type:feature A new feature request and removed category:api labels Dec 15, 2022
@Golodhros
Copy link
Member

@xfiderek what's the status of this work?

@xfiderek
Copy link
Contributor Author

xfiderek commented Feb 6, 2023

hey @Golodhros. I've created formal RFC as discussed: amundsen-io/rfcs#49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend From the Frontend folder keep fresh Disables stalebot from closing an issue rfc Indicates that there is an RFC associated with this issue. type:feature A new feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants