Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update docker environment and image versions for ecs deployment #1640

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

peterxichen
Copy link

Signed-off-by: Peter Chen [email protected]

Summary of Changes

Tests

N/A - this functionality is not currently tested

Documentation

N/A - consistent with existing documentation (https://github.com/amundsen-io/amundsen/blob/master/docs/installation-aws-ecs/aws-ecs-deployment.md)

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

@peterxichen peterxichen requested a review from a team as a code owner December 28, 2021 22:51
@boring-cyborg boring-cyborg bot added area:all Related to all the project area:docs labels Dec 28, 2021
@stale
Copy link

stale bot commented Jan 11, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Jan 11, 2022
@feng-tao feng-tao added the keep fresh Disables stalebot from closing an issue label Jan 24, 2022
@stale stale bot removed the stale label Jan 24, 2022
@feng-tao feng-tao closed this Feb 10, 2022
@feng-tao feng-tao reopened this Feb 10, 2022
@lhoss
Copy link

lhoss commented Mar 29, 2022

Too bad, this PR hasn't been merged yet !
I just went through the AWS ECS deployment (state of the main branch), which worked well .. until running the example/scripts/sample_data_loader.py script , which failed of course expecting an ES >v7.x (using main branch).
I guess I've 2 options now:

  • redo the deployment with @peterxichen 's changes here
  • or using an older databuilder version working with ES v6.x
    • which version ?
    • older commit then cdcf738 ?

@mgorsk1 mgorsk1 mentioned this pull request Mar 31, 2022
4 tasks
@Golodhros Golodhros added type:documentation A documentation improvement task and removed area:docs labels Dec 15, 2022
@Golodhros
Copy link
Member

@lhoss would you be open to take over this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:all Related to all the project keep fresh Disables stalebot from closing an issue type:documentation A documentation improvement task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants