Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TUI channel panics #63

Merged
merged 3 commits into from
May 1, 2024
Merged

Fix TUI channel panics #63

merged 3 commits into from
May 1, 2024

Conversation

devyn
Copy link
Contributor

@devyn devyn commented Apr 29, 2024

Fix panics when sending to the TUI channel.

Because failing to send just means the other end hung up, we don't really need to do anything special. It's totally expected that the other side will hang up eventually. It's best for us to just break out of the loop.

This also updates nushell to a revision I have right now that fixes local socket, but this should probably be changed on release.

@amtoine
Copy link
Owner

amtoine commented Apr 29, 2024

amazing, thanks @devyn, that solves my part of #55 🥳

@WindSoilder, could you try and see if that's any better on your side? 😇

because we are so close to the release, i'll wait a bit and bump to 0.93.0 when it's there so that dependencies are clean and stable again 🙏

@WindSoilder
Copy link

Thanks! I've played with it, and it works fine to me

@amtoine
Copy link
Owner

amtoine commented May 1, 2024

there it is, all working 😌

@amtoine amtoine merged commit 15d8701 into amtoine:main May 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants