support editing data cells #6

amtoine · 2023-08-22T17:32:06Z

add $.editor to the config which has the following type

record<
    frame: record<background: color, foreground: color>,
    buffer: record<background: color, foreground: color>
>

allow editing string cells in the data
show errors on the screen, e.g. when trying to edit a non-string cells
add / move Nushell-related functions to src/nu/

greatly inspired by - https://github.com/ratatui-org/ratatui/blob/add578a/examples/user_input.rs - https://github.com/ratatui-org/ratatui/blob/add578a/examples/popup.rs

this should allow to edit the text in the editor buffer.

this commit also returns an "error" when edit is launched on non-string values.

this test cannot run for now because non-string editing is not allowed.

this will make later debugging / improving `mutate_value_cell` a lot easier.

this allows to stay at the same place when confirming an edition.

this also resizes the editor between each key stroke.

this avoids collapsing the editor to 0 line when the buffer is empty, which looks bad in the TUI.

this should solve the merge conflicts with the main branch.

amtoine added 27 commits August 21, 2023 20:46

add edit.rs

2432609

greatly inspired by - https://github.com/ratatui-org/ratatui/blob/add578a/examples/user_input.rs - https://github.com/ratatui-org/ratatui/blob/add578a/examples/popup.rs

add the editor the the state

b25ea51

enter the editor when entering INSERT mode

051cf77

render the editor buffer when in INSERT mode

6dc05ac

start the editor with the Value under the cursor

443b936

unalign the editor window with the first column

51eacc9

call editor commands from the main app loop

bd5b570

this should allow to edit the text in the editor buffer.

allow only editing strings

7cfe7ed

allow TransitionResult to be an "error"

e0cfa8c

this commit also returns an "error" when edit is launched on non-string values.

return and set the new value when quitting editing

51f3033

do not allow to quit from INSERT mode with q

bd498dc

make Clippy happy

07cd797

remove a failling test

e083aa6

this test cannot run for now because non-string editing is not allowed.

refactor the value mutation in a function

eef902e

implement a recursive value cell mutation

32b70e4

panic instead of return dummy values

b0372c0

this will make later debugging / improving `mutate_value_cell` a lot easier.

return the value itself if the cell_path is incorrect

70b43a1

add test cases for mutate_value_cell

92af518

activate the "edition" test to make the tests fail

e046630

do not reset the cell path after mutating the value

a4a5687

this allows to stay at the same place when confirming an edition.

move the "edition" key handling to edit.rs

a7d35da

move the nushell-related stuff to inline app.rs modules

8e0415b

simplify the Editor::delete_char method

9c5f5d9

add support to delete a char with Del

2c21c3a

refactor the character deletion in a function

6151071

move the inline app.rs modules to nu/

27031c1

compile nu::cell_path only during tests

2efe508

amtoine mentioned this pull request Aug 22, 2023

Value::update_data_at_cell_path does not mutate the data #7

Open

amtoine added 2 commits August 26, 2023 11:17

render a blocking error when editing invalid cell

d896ecf

give better error message

0b9bea4

amtoine added 13 commits August 26, 2023 11:17

add a TODO in the source

218503d

update the TODO tasks in the README

f39a9de

update the hints in the bar

7d87fa0

render Enter, Backspace and Del with unicode

f29aa86

make the editor colors configurable

f789b85

put the editor box at the bottom

74a0378

allow the editor to move cursor up and down

f74e3fc

this also resizes the editor between each key stroke.

make Clippy happy

3c237b9

make sure the editor is at least 1 line tall

2561b47

this avoids collapsing the editor to 0 line when the buffer is empty, which looks bad in the TUI.

move the empty failing test to edit.rs

8f616c9

implement the test

56ffab7

fix: do not use -1 as a usize when deleting a char

e7a50fe

Merge remote-tracking branch 'origin/main' into edition

b952be8

this should solve the merge conflicts with the main branch.

amtoine marked this pull request as ready for review August 26, 2023 17:26

amtoine merged commit 98e66fb into main Aug 26, 2023
4 checks passed

amtoine deleted the edition branch August 26, 2023 17:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

support editing data cells #6

support editing data cells #6

amtoine commented Aug 22, 2023 •

edited

Loading

support editing data cells #6

support editing data cells #6

Conversation

amtoine commented Aug 22, 2023 • edited Loading

amtoine commented Aug 22, 2023 •

edited

Loading