bump to include foreground patch #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
amtoine
added a commit
that referenced
this pull request
Apr 13, 2024
this PR - makes it that `nu::value::is_table` returns a `nu::value::Table` variant which hold more information about why the value is not a table - adds a warning banner at the bottom to indicate the user why they are seeing a list of records - adds a bunch of new tests for `is_table` for the new table variants - make the colors of the warning banner configurable > **Important** > this will only work with #41, this can be achieved by running > ```bash > git merge bump-set_foreground > ``` > on top of this commit
this should solve the merge conflict in #41 where the lock file did change.
|
once the CI turns 🟢, i'll land this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to
thanks @devyn for being part of that PR 🙏