Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test the Nupm installation #53

Merged
merged 8 commits into from
Nov 3, 2023
Merged

test the Nupm installation #53

merged 8 commits into from
Nov 3, 2023

Conversation

amtoine
Copy link
Owner

@amtoine amtoine commented Nov 3, 2023

after talking with @stormasm about the new nu-git-manager / nu-git-manager-sugar install, i thought we could try to test the Nupm install inside our CI.

this PR is this experiment:

  • install Nupm with itself in an extra CI step
  • use ~/.local/share/nupm/modules/nupm as the standard location for the nupm package
  • add the install-package test which
    • installs nu-git-manager to the Nupm store
    • checks that there is no scripts
    • checks that there are the two nu-git-manager and nu-git-manager-sugar modules installed

Note
currently there is no --no-confirm option for nupm install, so the NUPM_HOME has to be created manually with mkdir prior to the install => i've added FIXMEs for that
should be fixed with nushell/nupm#42

@amtoine amtoine added ci Something related to the Continuous Integration tests Something related to the tests of the library labels Nov 3, 2023
@amtoine amtoine marked this pull request as ready for review November 3, 2023 09:53
Copy link
Collaborator

@melMass melMass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 Super cool

@melMass melMass merged commit 33ffb98 into main Nov 3, 2023
3 checks passed
@amtoine amtoine deleted the test-nupm-install branch November 3, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Something related to the Continuous Integration tests Something related to the tests of the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants