append a base element to force the baseURI of the FakeWindow
#40218
+11
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwinmombay
force-pushed
the
test-another-pr
branch
2 times, most recently
from
8d35f61 to
1c48092
Compare
erwinmombay
force-pushed
the
test-another-pr
branch
from
1c48092 to
5eb5b2b
Compare
danielrozenberg
approved these changes
Jan 8, 2025
erwinmombay
added a commit
to erwinmombay/amphtml
that referenced
this pull request
Jan 8, 2025
this was fixed in ampproject#40218
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves some of the url issues we've been dealing with on the chromdriver 131 upgrade
there seems to have been a change between chrome 119 to chrome 131 on how the baseURI is inherited. We can force the baseURI of the FakeWindow by appending a
baseelement on construction in fake-dom.jsSee #40214