🏗 Add cdn to error reporting function, and update amp-errors.md
#39635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielrozenberg
force-pushed
the
error-report-with-cdn-url
branch
from
71fb9f5 to
7c53a4b
Compare
erwinmombay
reviewed
Nov 17, 2023
| @@ -10,23 +10,37 @@ the `betaErrorReportingUrl` config. E.g. for `cdn.ampproject.org` | |||
| The following fields are reported: | |||
|
|
|||
| - `v=string` - AMP version | |||
| - `noamp={0,1}` - whether the document contains non-AMP JavaScript | |||
There was a problem hiding this comment.
was this just missed documentation before? (i do see in the testing code below, but just double checking)
There was a problem hiding this comment.
Yeah, looks like we kept adding fields in error-reporting.js but rarely updated amp-errors.md to correspond. I wish we had something like go/ifttt for GitHub 😅
erwinmombay
approved these changes
Nov 17, 2023
eszponder
pushed a commit
to krzysztofequativ/amphtml
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support error reporting for different CDNs