Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ibeat support for new param for content exclusion #39593

Merged
merged 8 commits into from
Nov 9, 2023

Conversation

denmark-admin
Copy link
Contributor

✨ Added support for a new parameter for ibeat analytics to capture content exclusion codes from users.

@amp-owners-bot amp-owners-bot bot requested a review from avimehta November 1, 2023 08:43
@erwinmombay erwinmombay requested review from powerivq and removed request for avimehta November 8, 2023 00:34
@erwinmombay
Copy link
Member

@powerivq could you take a look at this. thanks

@powerivq
Copy link
Contributor

powerivq commented Nov 8, 2023

Can you rebase against latest main branch, so that the test could pass?

@powerivq
Copy link
Contributor

powerivq commented Nov 8, 2023

@denmark-admin

@powerivq powerivq merged commit 2659ea7 into ampproject:main Nov 9, 2023
10 checks passed
eszponder pushed a commit to krzysztofequativ/amphtml that referenced this pull request Apr 22, 2024
* added new params for ibeat analytics

* Added new input parameter vct for IbeatAnalytics tag

* Restored newline as per code review comment

* Added new property support for content exclusion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants