🐛 Remove gplus from amp-social-share

[drewroberts]

Fixes #21743

Remove Google+ from amp-social-share.

CC: @aghassemi and the other 2 owners from amp-social-share .yaml @ithinkihaveacat @RyanCopley

[RyanCopley]

It may be worth reviewing all instances of gplus. https://github.com/ampproject/amphtml/search?utf8=%E2%9C%93&q=gplus

[drewroberts]

@RyanCopley I removed the other 5 instances of gplus. Let me know if there's anything else you recommend. Thanks for the opportunity to work on the AMP Project.

[cathyxz]

We should also remove references to gplus from AMP-By-Example, e.g. https://amp.dev/documentation/examples/components/amp-social-share/?referrer=ampbyexample.com. In fact we should probably remove those first so that those pages don't break. Should we have a deprecation notice out for a bit before actually removing this (to avoid breaking people)?

[drewroberts]

Good call, @cathyxz. I created an issue for it and working on it now:

• Remove gplus from Examples amp-by-example#1998

What's the best practice for creating a deprecation notice?

[aghassemi]

To keep things backward-compatible, we can't completely remove this. Since if a site is using gplus share, it will endup as blank space which is arguably worse:

I suggest only removing it from documentation and examples.

[aghassemi]

For deprecation, probably a user().warn when encountering gplus in the config would do.

[nainar]

Closing this PR as inactive. Please reopen if that isn't the case (preferably as a new PR).