Skip to content

Commit

Permalink
Update some files that failed validator test
Browse files Browse the repository at this point in the history
  • Loading branch information
@banaag
banaag committed Jan 9, 2025
1 parent 214f3a5 commit a480ab1
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 109 deletions.
106 changes: 0 additions & 106 deletions extensions/amp-story/1.0/test/validator-amp-story-amp-social-share.out
View file
Original file line number Diff line number Diff line change
Expand Up @@ -103,110 +103,4 @@ amp-story/1.0/test/validator-amp-story-amp-social-share.html:90:6 The attribute
| </amp-story>
| </body>
|
| </html>
FAIL
| <!--
| Test Description:
| Tests for the amp-social-share component inside amp-story.
| -->
| <!doctype html>
| <html ⚡ lang="en">
|
| <head>
| <meta charset="utf-8">
| <script async src="https://cdn.ampproject.org/v0.js"></script>
| <script async custom-element="amp-story" src="https://cdn.ampproject.org/v0/amp-story-1.0.js"></script>
| <script async custom-element="amp-social-share" src="https://cdn.ampproject.org/v0/amp-social-share-0.1.js"></script>
| <title>My Story</title>
| <meta name="description" content="Get started with amp-story">
| <link rel="canonical" href="validator-amp-social-share.html">
| <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1">
| <style amp-boilerplate>
| body {
| -webkit-animation: -amp-start 8s steps(1, end) 0s 1 normal both;
| -moz-animation: -amp-start 8s steps(1, end) 0s 1 normal both;
| -ms-animation: -amp-start 8s steps(1, end) 0s 1 normal both;
| animation: -amp-start 8s steps(1, end) 0s 1 normal both
| }
|
| @-webkit-keyframes -amp-start {
| from {
| visibility: hidden
| }
|
| to {
| visibility: visible
| }
| }
|
| @-moz-keyframes -amp-start {
| from {
| visibility: hidden
| }
|
| to {
| visibility: visible
| }
| }
|
| @-ms-keyframes -amp-start {
| from {
| visibility: hidden
| }
|
| to {
| visibility: visible
| }
| }
|
| @-o-keyframes -amp-start {
| from {
| visibility: hidden
| }
|
| to {
| visibility: visible
| }
| }
|
| @keyframes -amp-start {
| from {
| visibility: hidden
| }
|
| to {
| visibility: visible
| }
| }
| </style><noscript>
| <style amp-boilerplate>
| body {
| -webkit-animation: none;
| -moz-animation: none;
| -ms-animation: none;
| animation: none
| }
| </style>
| </noscript>
| </head>
|
| <body>
| <amp-story standalone title="My Story" publisher="Me" publisher-logo-src="http://me.com/logo.png"
| poster-portrait-src="http://me.com/poster.jpg">
| <amp-story-page id="fill-template-title">
| <amp-social-share
>> ^~~~~~~~~
amp-story/1.0/test/validator-amp-story-amp-social-share.html:90:6 The attribute 'class' in tag 'amp-social-share' is set to the invalid value 'i-amphtml-layout-fixed i-amphtml-layout-size-defined amp-social-share-system i-amphtml-built i-amphtml-layout i-amphtml-element'. (see https://amp.dev/documentation/guides-and-tutorials/develop/style_and_layout/style_pages/#disallowed-styles)
>> ^~~~~~~~~
amp-story/1.0/test/validator-amp-story-amp-social-share.html:90:6 The attribute 'i-amphtml-layout' may not appear in tag 'amp-social-share'. (see https://amp.dev/documentation/components/amp-social-share)
| class="i-amphtml-layout-fixed i-amphtml-layout-size-defined amp-social-share-system i-amphtml-built i-amphtml-layout i-amphtml-element"
| aria-label="Share" type="system" width="48" height="48" i-amphtml-layout="fixed"
| style="width: 48px; height: 48px;" role="button" tabindex="0"></amp-social-share>
| <amp-story-grid-layer template="vertical">
| <p>Content</p>
| </amp-story-grid-layer>
| </amp-story-page>
| </amp-story>
| </body>
|
| </html>
14 changes: 11 additions & 3 deletions validator/testdata/feature_tests/duplicate_attribute.out.cpponly
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,13 @@ FAIL
| <script async src="https://cdn.ampproject.org/v0.js"></script>
| <!-- These two duplicate a custom-element attribute used as a dispatch key -->
| <script async custom-element="amp-image-lightbox" custom-element="duplicate" src="https://cdn.ampproject.org/v0/amp-image-lightbox-0.1.js"></script>
>> ^~~~~~~~~
feature_tests/duplicate_attribute.html:15:2 The tag 'script' contains the attribute 'custom-element' repeated multiple times.
| <script async custom-element="duplicate" custom-element="amp-youtube" src="https://cdn.ampproject.org/v0/amp-youtube-0.1.js"></script>
>> ^~~~~~~~~
feature_tests/duplicate_attribute.html:16:2 The attribute 'custom-element' may not appear in tag 'amphtml engine script'. (see https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup)
feature_tests/duplicate_attribute.html:16:2 The tag 'script' contains the attribute 'custom-element' repeated multiple times.
>> ^~~~~~~~~
feature_tests/duplicate_attribute.html:16:2 The attribute 'custom-element' may not appear in tag 'amp-youtube v0.1 extension script'. (see https://amp.dev/documentation/components/amp-youtube)
|
| </head>
| <body>
Expand All @@ -33,9 +37,13 @@ feature_tests/duplicate_attribute.html:23:3 The tag 'amp-img' contains the attri
|
| <!-- Let's make sure the script type can't be overridden -->
| <script type="application/ld+json" type="text/javascript">{}</script>
>> ^~~~~~~~~
feature_tests/duplicate_attribute.html:26:3 The tag 'script' contains the attribute 'type' repeated multiple times.
| <script type="text/javascript" type="application/ld+json">{}</script>
>> ^~~~~~~~~
feature_tests/duplicate_attribute.html:27:3 The parent tag of tag 'amphtml engine script' is 'body', but it can only be 'head'. (see https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup)
feature_tests/duplicate_attribute.html:27:3 The tag 'script' contains the attribute 'type' repeated multiple times.
>> ^~~~~~~~~
feature_tests/duplicate_attribute.html:27:3 The attribute 'type' in tag 'script type=application/ld+json' is set to the invalid value 'text/javascript'.
|
| </body>
| </html>
| </html>

0 comments on commit a480ab1

Please sign in to comment.