🏗 Partial updates for core devDependencies (#39759)

ampproject · Jan 25, 2024 · 7ee5198 · 7ee5198
1 parent 36fa762
commit 7ee5198
Show file tree

Hide file tree

Showing 5 changed files with 7,541 additions and 8,859 deletions.
diff --git a/build-system/babel-plugins/babel-plugin-amp-story-supported-languages/index.js b/build-system/babel-plugins/babel-plugin-amp-story-supported-languages/index.js
@@ -22,12 +22,8 @@ module.exports = function ({types: t}) {
   return {
     name: 'amp-story-supported-languages',
     visitor: {
-      // Ignore 'ReferencedIdentifier' does not exist in type 'Visitor<PluginPass>'.
-      // The tests prove that this type of visitor works with the current
-      // version of babel we use.
-      // @ts-ignore
       ReferencedIdentifier(path) {
-        if (path.get('name').node !== 'AMP_STORY_SUPPORTED_LANGUAGES') {
+        if (path.node.name !== 'AMP_STORY_SUPPORTED_LANGUAGES') {
           return;
         }
 

diff --git a/build-system/babel-plugins/babel-plugin-nomodule-loader/index.js b/build-system/babel-plugins/babel-plugin-nomodule-loader/index.js
@@ -27,7 +27,7 @@ module.exports = function (babel) {
 
   /**
    * @param {object} replacements
-   * @return {babel.Node}
+   * @return {babel.types.Statement}
    */
   function buildWrapper(replacements) {
     if (!wrapperTemplate) {
@@ -44,7 +44,7 @@ module.exports = function (babel) {
 
   /**
    * @param {babel.NodePath<import('@babel/types').Program>} path
-   * @param {babel.Node} wrapper
+   * @param {babel.types.Statement} wrapper
    */
   function injectWrapper(path, wrapper) {
     const {body, directives} = path.node;

diff --git a/build-system/common/utils.js b/build-system/common/utils.js
@@ -36,7 +36,7 @@ function getExperimentConfig(experiment) {
     config?.name &&
     config?.define_experiment_constant &&
     config?.expiration_date_utc &&
-    new Number(new Date(config.expiration_date_utc)) >= Date.now();
+    Number(new Date(config.expiration_date_utc)) >= Date.now();
   return valid ? config : null;
 }