Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix form-label lint errors #7823

Merged
merged 1 commit into from
Jun 25, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions assets/src/onboarding-wizard/pages/technical-background/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,7 @@ export function TechnicalBackground() {
className={`technical-background-option-container`}
selected={true === developerToolsOption}
>
<label
htmlFor={enableInputID}
className="technical-background-option"
>
<div className="technical-background-option">
<div className="technical-background-option__input-container">
<input
type="radio"
Expand All @@ -76,7 +73,10 @@ export function TechnicalBackground() {
/>
</div>
<User1 />
<div className="technical-background-option__description">
<label
htmlFor={enableInputID}
className="technical-background-option__description"
>
<h2>
{__('Developer or technically savvy', 'amp')}
</h2>
Expand All @@ -86,15 +86,15 @@ export function TechnicalBackground() {
'amp'
)}
</p>
</div>
</label>
</label>
</div>
</Selectable>

<Selectable
className={`technical-background-option-container`}
selected={false === developerToolsOption}
>
<label
<div
htmlFor={disableInputID}
className="technical-background-option"
>
Expand All @@ -109,7 +109,10 @@ export function TechnicalBackground() {
/>
</div>
<User2 />
<div className="technical-background-option__description">
<label
htmlFor={disableInputID}
className="technical-background-option__description"
>
<h2>
{__(
'Non-technical or wanting a simpler setup',
Expand All @@ -122,8 +125,8 @@ export function TechnicalBackground() {
'amp'
)}
</p>
</div>
</label>
</label>
</div>
</Selectable>
</form>
</div>
Expand Down
Loading