Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHPCS errors/warnings #7638

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Fix PHPCS errors due to `Universal.CodeAnalysis.NoEchoSprintf.Found` …

733f1b4
Select commit
Loading
Failed to load commit list.
Draft

Fix PHPCS errors/warnings #7638

Fix PHPCS errors due to `Universal.CodeAnalysis.NoEchoSprintf.Found` …
733f1b4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 11, 2023 in 1s

78.49% (+0.69%) compared to 92538fb

View this Pull Request on Codecov

78.49% (+0.69%) compared to 92538fb

Details

Codecov Report

Merging #7638 (733f1b4) into develop (92538fb) will increase coverage by 0.69%.
The diff coverage is 85.52%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #7638      +/-   ##
=============================================
+ Coverage      77.79%   78.49%   +0.69%     
  Complexity      6909     6909              
=============================================
  Files            277      210      -67     
  Lines          23419    22228    -1191     
=============================================
- Hits           18218    17447     -771     
+ Misses          5201     4781     -420     
Files Coverage Δ
includes/class-amp-comment-walker.php 0.00% <ø> (ø)
includes/class-amp-service-worker.php 80.40% <100.00%> (ø)
includes/class-amp-theme-support.php 88.51% <100.00%> (ø)
includes/embeds/class-amp-issuu-embed-handler.php 15.00% <ø> (ø)
includes/embeds/class-amp-meetup-embed-handler.php 27.27% <ø> (ø)
includes/embeds/class-amp-reddit-embed-handler.php 15.00% <ø> (ø)
...nitizers/class-amp-nav-menu-dropdown-sanitizer.php 88.33% <100.00%> (ø)
...ludes/sanitizers/class-amp-o2-player-sanitizer.php 100.00% <ø> (ø)
...cludes/sanitizers/class-amp-playbuzz-sanitizer.php 95.45% <ø> (ø)
...nitizers/class-amp-tag-and-attribute-sanitizer.php 96.35% <ø> (ø)
... and 15 more

... and 67 files with indirect coverage changes