Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] [amp-stories] 1541 - Blacklist root elements which are not Page #1616

Closed
wants to merge 1 commit into from
Closed

[WIP] [amp-stories] 1541 - Blacklist root elements which are not Page #1616

wants to merge 1 commit into from

Conversation

mehigh
Copy link
Contributor

@mehigh mehigh commented Nov 15, 2018 •
edited
Loading

Fixes #1541

@mehigh mehigh requested a review from miina November 15, 2018 14:07
@mehigh mehigh mentioned this pull request Nov 15, 2018
Closed
2 tasks
@miina miina changed the title 1541 - Blacklist root elements which are not Page [WIP] [WIP] [amp-stories] 1541 - Blacklist root elements which are not Page Nov 19, 2018
@miina
Copy link
Contributor

miina commented Nov 22, 2018 •
edited
Loading

@mehigh Looks like there is a way now how to remove the elements except for Page within Gutenberg, so we're not going to need to hide it with CSS afterall 🎉

Closing this PR in favor of #1644 .

@miina miina closed this Nov 22, 2018
@miina miina deleted the 1541-root-blacklist branch November 22, 2018 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miina miina Awaiting requested review from miina

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mehigh @miina