Orchestrator Updates #207
Orchestrator Updates #207
Conversation
aalavandhan
requested review from
thegostep,
brandoniles and
ahnaguib
and removed request for
thegostep and
brandoniles
|
@tedwu13 you can review this too |
| @@ -1,53 +1,72 @@ | |||
| pragma solidity 0.7.6; | |||
| // SPDX-License-Identifier: GPL-3.0-or-later | |||
| pragma solidity 0.8.2; | |||
There was a problem hiding this comment.
0.8 is really tempting but... the latest version that slither recommends is 0.7.6:
https://github.com/crytic/slither/wiki/Detector-Documentation#incorrect-versions-of-solidity
(changed just a few days ago from 0.6.11)
Are there any features from 0.8 that you need?
There was a problem hiding this comment.
I feel like keeping up with the latest version that openzeppelin contracts use is a good practice. They are up to 0.8x now
@thegostep thoughts?
contracts/Orchestrator.sol
Outdated
| constructor(address policy_) public { | ||
| Ownable.initialize(msg.sender); | ||
| policy = UFragmentsPolicy(policy_); | ||
| constructor(address policy_) { |
There was a problem hiding this comment.
Need to call the base constructor too?
There was a problem hiding this comment.
not really required with newer versions.
https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/access/Ownable.sol#L26
But will add it for the sake of being explicit
Co-authored-by: Brandon Iles <[email protected]>
Co-authored-by: Brandon Iles <[email protected]>
aalavandhan
force-pushed
the
orch-v2
branch
2 times, most recently
from
10ebf06
to
542d176
Compare
Fixes issues listed in #192