New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add `_` to host validation #372

Open

maximal wants to merge 1 commit into amphp:3.x from maximal:patch-1

maximal commented Oct 21, 2024

Local hosts can contain underscores. For example in Docker contexts (application/services names).


          Add _ to host validation

ba74074

kelunik reviewed

View reviewed changes

Member

kelunik left a comment

Hmmm... underscores are not valid in hostnames or domain labels as far as I know.

Any reason why you try to use underscores instead of dashes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet