Skip to content

Commit

Permalink
Update tests for CombinatorException, prepare tag 1.0.5
Browse files Browse the repository at this point in the history
  • Loading branch information
bwoebi committed Sep 30, 2015
1 parent 00898cd commit 3057329
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 10 deletions.
4 changes: 2 additions & 2 deletions CHANGELOG
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# dev
### 1.0.5

- Convert general `\RuntimeException` to more specific
- Convert general `RuntimeException` to more specific
`Amp\CombinatorException`.

### 1.0.4
Expand Down
4 changes: 1 addition & 3 deletions lib/CombinatorException.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,4 @@

namespace Amp;

class CombinatorException extends \RuntimeException {

}
class CombinatorException extends \RuntimeException {}
10 changes: 5 additions & 5 deletions test/FunctionsTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,7 @@ public function testSomeFailsImmediatelyOnEmptyPromiseArrayInput() {
}

/**
* @expectedException \RuntimeException
* @expectedException \Amp\CombinatorException
*/
public function testSomeThrowsIfNoPromisesResolveSuccessfully() {
\Amp\some([
Expand Down Expand Up @@ -481,7 +481,7 @@ public function testNonPromiseValueImmediatelyResolvesFirstCombinator() {
}

/**
* @expectedException \RuntimeException
* @expectedException \Amp\CombinatorException
* @expectedExceptionMessage All promises failed
*/
public function testFirstFailsIfAllPromisesFail() {
Expand All @@ -494,7 +494,7 @@ public function testFirstFailsIfAllPromisesFail() {
}

/**
* @expectedException \RuntimeException
* @expectedException \Amp\TimeoutException
* @expectedExceptionMessage Promise resolution timed out
*/
public function testTimeout() {
Expand All @@ -521,7 +521,7 @@ public function testTimeoutOnSuccess() {
}

/**
* @expectedException RuntimeException
* @expectedException \RuntimeException
* @expectedExceptionMessage nothing that is worth knowing can be taught
*/
public function testTimeoutOnFailure() {
Expand Down Expand Up @@ -625,7 +625,7 @@ public function testExplicitAnyCombinatorResolution() {
}

/**
* @expectedException \RuntimeException
* @expectedException \Amp\CombinatorException
*/
public function testExplicitSomeCombinatorResolutionFailsOnError() {
\Amp\run(function () {
Expand Down

0 comments on commit 3057329

Please sign in to comment.