-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for AMF v2 #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or cdl:colorCorrectionRef
…ansformType. - remove applied tag from aces:inputTransformType and and aces:lookTransform type as they inheriet from aces:transformType.
- updates email regex checking to be more permissive. This should allow unicode charaters in email as it only requires characters to be followed by an @ symbol to be followed by characters.
- require the uuid tag under amfInfo tag. This is need to require there's a unique tag in the AMF that allow OCIO to build a config that works for more than one AMF at a time. (e.g. supporting a VFX shot that has 10 clips that are inputs to the shot)
- supports transformID v1.5 syntax
…v2_stage * v2_updates/optional-output-transforms: make outputTransform element optional # Conflicts: # schema/acesMetadataFile.xsd
* v2_updates/colorCorrectionRef: specify that exactly one cdl:colorCorrectionRef is required add support for location of .ccc or .cdl files that include ref ids for cdl:colorCorrectionRef
* v2_updates/email-regex-update: update email regex
* v2_updates/require-amfInfo-uuid: require amfInfo uuid
* v2_updates/csc-as-idt: add support to ACEScsc transforms to be used as IDTs
…v2_stage * v2_updates/optional-output-transforms: make outputTransform element optional
* v2_updates/workingLocation: update and add amf examples add workingLocation tag
aforsythe
force-pushed
the
v2_updates/v2_stage
branch
from
December 27, 2023 02:01
1c37f85
to
7b4d3ec
Compare
- previous logic causes the applied tag to have to exist on the sub-elements of <outputTransform> (e.g. <referenceRenderingTransform> and <outputDeviceTransform>)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to AMF for AMF v2.