Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not suggest inside comments #983

Closed

Conversation

peltevis
Copy link

ALS shouldn't provide suggestions inside YAML comments.

Initially I was aiming to fix #894 but I later realized that the problem wasn't that we are not replacing existing text but rather that ALS is providing suggestions inside YAML comments

(P.S @agusayerza here, current repository configuration doesn't let me open an PR from my original account for somereason 🤷)

@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @peltevis to sign the Salesforce Inc. Contributor License Agreement.

@salesforce-cla
Copy link

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Agustín Ayerza <a***@A***.f***.c***.ar>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce Inc. Contributor License Agreement and this Pull Request will be revalidated.

@agusayerza agusayerza force-pushed the do-not-suggest-inside-comments branch from 6158b1f to 11db66d Compare October 20, 2023 03:23
@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @agusayerza to sign the Salesforce Inc. Contributor License Agreement.

@peltevis peltevis closed this Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$ref autocomplete does not replace existing text
2 participants