made some minor cleanup #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klobuczek
commented
Feb 8, 2018
| @@ -2,6 +2,6 @@ module CanCanCan | |||
| end | |||
| module CanCanCan | |||
| module Neo4j | |||
| VERSION = '0.1.0'.freeze | |||
| VERSION = '1.0.0.beta1'.freeze | |||
There was a problem hiding this comment.
This component is nearly complete. Let's don't scare people with a low version.
klobuczek
commented
Feb 8, 2018
| @@ -58,7 +56,7 @@ | |||
| article2 = Article.create!(published: true, secret: true) | |||
| article3 = Article.create!(published: false, secret: true) | |||
| Article.create!(published: false, secret: false) | |||
| expect(Article.accessible_by(@ability).to_a).to eq([article1, article2, article3]) | |||
| expect(Article.accessible_by(@ability)).to contain_exactly(article1, article2, article3) | |||
There was a problem hiding this comment.
without order by clause order is not guaranteed. Order could be achieved by passing a scope to the rule. Is that possible?
klobuczek
commented
Feb 8, 2018
| simplecov (~> 0.12) | ||
|
|
||
| BUNDLED WITH | ||
| 1.16.1 |
There was a problem hiding this comment.
Gemfile.lock is never committed for gems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just making sure this workflow works. Let's start doing the branch, PR, review, workflow so I can participate more.