Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export public key for external usage: ASN1 (Java supported key) #51

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hatemalimam
Copy link

As discussed here I'm opening this PR.

Please review the code, at my backend part it's working like a charm.

Thanks.

@amitaymolko
Copy link
Owner

Thanks for taking the time to contribute!

Looks good!
But, you forgot to add Android support for that function.
We can't have this returning an error on Android.

Thanks!

@hatemalimam
Copy link
Author

Firstly I thought the android part is generating a sane key,
so I thought to call getPublicKey in the newly introduced method,
but strangely testing the android key, it's missed up as the iOS one !
I didn't expect that, I'm inspecting the use of spongycastle...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants