Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Simplified Agent Installer #1352

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

SoarinFerret
Copy link

The goal of this PR is to update the current agent installer (primarily for linux) to provide a simple command to copy/paste and then run on a remote server without having to copy an installer script around. If this is something of use to the devs, I would like to continue the work here to allow the same functionality on Windows. The macOS install command is pretty close to this already.

Here are the UI changes (provided in a separate PR on the amidaware/tacticalrmm-web repo)

image

image

@CLAassistant
Copy link

CLAassistant commented Nov 14, 2022

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Attention: Patch coverage is 59.52381% with 17 lines in your changes missing coverage. Please review.

Project coverage is 82.09%. Comparing base (0343ee4) to head (e3cb957).
Report is 666 commits behind head on develop.

Files with missing lines Patch % Lines
api/tacticalrmm/agents/utils.py 64.28% 10 Missing ⚠️
api/tacticalrmm/agents/views.py 50.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1352      +/-   ##
===========================================
- Coverage    82.34%   82.09%   -0.25%     
===========================================
  Files          114      114              
  Lines         7527     7558      +31     
===========================================
+ Hits          6198     6205       +7     
- Misses        1329     1353      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wh1te909
Copy link
Member

Thanks for starting this, since the linux/mac agents are still in beta they are probably going to change a lot as I am just experimenting with stuff but my plan was to eventually get rid of the bash scripts for installing so this looks like a good start.

We're actually working on a contributing guide for both this and the web repo but it's not quite ready yet, so until then I'll just post a snippet from the contributing guide for python specifically, please incorporate this into your PR and lmk if have any questions on them. You can look through the code for examples of all of the below:

  • All Django code submitted to the main tacticalrmm repo must have 100% unit test coverage.
  • Lines that are not part of your change should not be edited (e.g. don't format
    unchanged lines, don't reorder existing imports)
  • All python files must be formatted with black
  • Type hints are required and will be enforced.
  • With the exception of Django or DRF view functions, all functions must be fully type annotated and enforce named arguments (PEP 3102). Example:
# bad
def add_two_numbers(num1, num2):
    return num1 + num2
# good
def add_two_numbers(*, num1: int, num2: int) -> int:
    return num1 + num2

@SoarinFerret
Copy link
Author

Thanks for the feedback, I'll do my best to incorporate those changes over the next couple of days!

@wh1te909 wh1te909 force-pushed the develop branch 2 times, most recently from 942055f to 903a2d6 Compare June 25, 2023 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants