Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart TRMM agent if it installs choco #41

Closed
wants to merge 1 commit into from

Conversation

silversword411
Copy link

@silversword411 silversword411 commented Dec 8, 2023

If TRMM agent installs choco anything choco fails because it wasn't in the %PATH% when agent was started.

Just restarting agent service should fix the problem. Hope this is the right spot to put ChatGPTs advise ;)

@wh1te909
Copy link
Member

wh1te909 commented Dec 8, 2023

restarting the agent from within itself requires more care and error handling. also this is not a trmm issue, since trmm agent uses the full path of choco to do choco related things, so choco not being in the path is irrelevant. community scripts or any scripts should not rely on path and always fallback to the full path of the binary if the exe is not found in the path, just how the trmm agent does it.

@wh1te909 wh1te909 closed this Dec 8, 2023
@silversword411
Copy link
Author

Note to self: git push --force-with-lease is your friend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants