-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the possibility to load both from string and path #74
Conversation
After discussing with @Giulero we decided to keep the keyword So the PR is now ready for review @S-Dafarra @Giulero |
As a side comment, it would be good to add one test case with an urdf loaded from text |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @CarlottaSartore ! If it is not a lot of effort, is it possible to wrap this piece of code in a function?
Yes! Great idea, done in 1726618! |
The tests are failing but seems due to idyntree pip issues, see the log Run python -m pip install --upgrade pip
Run python -m pip install --upgrade pip × Building wheel for idyntree (pyproject.toml) did not run successfully.
note: This error originates from a subprocess, and is likely not a problem with pip.
|
Thanks @CarlottaSartore ! Yup, the tests are failing since the action is not updated (PR #88). |
This PR adds the possibility to load the
urdf
both from string or from path.As discussed with @S-Dafarra, I decided not to declare any new method (e.g.
LoadFromXMLPath
,LoadFromXMLstring
)but to modify the current init to ensure back-compatibility