presentCountByDate and absentCountByDate #130
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @tejasai2007, thanks for the PR. I wanted to know if someone had asked you to make these queries in Root i.e. if this is part of a larger project involving Home. Also, a few things about your PR and commits:
These are some pretty standard practices in open source and it's very important that you respect them when contributing. |
ivinjabraham
requested changes
Jun 21, 2025
| @@ -24,3 +24,4 @@ tracing = "0.1.41" | |||
| tracing-subscriber = { version = "0.3.19", features = ["env-filter", "time", "fmt", "std"] } | |||
| dotenv = "0.15.0" | |||
| time = { version = "0.3.37", features = ["formatting"] } | |||
| anyhow = "1.0.98" | |||
There was a problem hiding this comment.
Doesn't seem to be used anywhere?
| @@ -41,4 +41,6 @@ impl AttendanceQueries { | |||
|
|
|||
| Ok(records) | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Make sure you run clippy/linting tools to avoid unnecessary additions like this.
| @@ -39,6 +42,11 @@ impl Config { | |||
|
|
|||
| #[tokio::main] | |||
| async fn main() { | |||
| dotenv().ok(); | |||
There was a problem hiding this comment.
Why do you think this is necessary?
|
Also, next time use the fixes/closes keyword in the PR body to link it with it's issue. (#124) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These queries calculate a member's present/absent days between two dates (excluding holidays), simplifying attendance tracking.