This repository has been archived by the owner on May 15, 2024. It is now read-only.
fix(one-app-server-bundler): serve-module read and write the module map once #623
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Read and write the module map from/to disk O(1) rather than O(n) in serve-module.
Motivation
Filesystem operations are slower than memory operations, so with #622 it'll be useful to reduce the total filesystem operations from
2*number of modules
to just2
.Should help reduce startup time with one-app-runner (albeit not as extreme as #622).
Test Conditions
existing tests pass 🙌
added a test to verify the thrown exception message when no modules are provided
Types of changes
Check boxes that apply:
Checklist
Check boxes that apply: