Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

fix: argument escaping #555

Merged
merged 3 commits into from
Aug 16, 2023
Merged

fix: argument escaping #555

merged 3 commits into from
Aug 16, 2023

Conversation

PixnBits
Copy link
Contributor

@PixnBits PixnBits commented Aug 8, 2023

Description

quote arguments to prevent them being separated during interpretation

Motivation

Avoid issues like

docker: invalid reference format.

due to spaces in paths.

Test Conditions

TDD by parsing the command issued and asserting argument segments.

Types of changes

Check boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist

Check boxes that apply:

  • My code follows the code style of this project.
  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • I have added the Apache 2.0 license header to any new files created.

@PixnBits PixnBits requested a review from a team August 11, 2023 23:00
@10xLaCroixDrinker 10xLaCroixDrinker enabled auto-merge (squash) August 16, 2023 22:00
@10xLaCroixDrinker 10xLaCroixDrinker merged commit 902395c into main Aug 16, 2023
8 checks passed
@10xLaCroixDrinker 10xLaCroixDrinker deleted the fix/argument-escaping branch August 16, 2023 22:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants