fix(externals): issue when no one-amex key

americanexpress · Sep 14, 2023 · 2676bda · 2676bda
1 parent cd83ead
commit 2676bda
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/packages/one-app-dev-bundler/__tests__/utils/bundle-external-fallbacks.spec.js b/packages/one-app-dev-bundler/__tests__/utils/bundle-external-fallbacks.spec.js
@@ -205,4 +205,13 @@ describe('bundle-external-fallbacks', () => {
     expect(console.error).toHaveBeenCalledWith('Failed to build fallback for external awesome for browser', error);
     expect(console.error).toHaveBeenCalledWith('Failed to build fallback for external awesome for node', error);
   });
+
+  it('does not fail when no one-amex config', async () => {
+    readPackageUpSync.mockImplementationOnce(() => ({
+      packageJson: {},
+    }));
+
+    await bundleExternalFallbacks();
+    expect(esbuild.build).not.toHaveBeenCalled();
+  });
 });
diff --git a/packages/one-app-dev-bundler/utils/bundle-external-fallbacks.js b/packages/one-app-dev-bundler/utils/bundle-external-fallbacks.js
@@ -28,7 +28,7 @@ const getExternalLibraryName = (name, version) => [EXTERNAL_PREFIX, snakeCase(na
  */
 export const bundleExternalFallbacks = async () => {
   const { packageJson } = readPackageUpSync();
-  const { 'one-amex': { bundler = {} } } = packageJson;
+  const { 'one-amex': { bundler = {} } = {} } = packageJson;
   const { requiredExternals } = bundler;
 
   if (