chore: review feedback

americanexpress · Apr 16, 2024 · 08d7262 · 08d7262
1 parent 12e8ebd
commit 08d7262
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/packages/one-app-bundler/__tests__/utils/writeToModuleConfig.spec.js b/packages/one-app-bundler/__tests__/utils/writeToModuleConfig.spec.js
@@ -46,7 +46,7 @@ describe('write-to-module-config', () => {
 
     it('successfully writes to module config', () => {
       writeToModuleConfig({ my: 'module-config' });
-      expect(fs.writeFileSync).toHaveBeenCalledWith('/mock-path/build/1.2.3/module-config.json', '{\n  "my": "module-config"\n}');
+      expect(fs.writeFileSync).toHaveBeenCalledWith('/mock-path/build/1.2.3/module-config.json', '{"my":"module-config"}');
     });
   });
 
@@ -62,7 +62,7 @@ describe('write-to-module-config', () => {
       writeToModuleConfig({ my: 'module-config' });
       expect(fs.writeFileSync).toHaveBeenCalledWith(
         '/mock-path/build/1.2.3/module-config.json',
-        '{\n  "hello": "im here",\n  "my": "module-config"\n}'
+        '{"hello":"im here","my":"module-config"}'
       );
     });
   });

diff --git a/packages/one-app-bundler/utils/writeToModuleConfig.js b/packages/one-app-bundler/utils/writeToModuleConfig.js
@@ -20,8 +20,9 @@ export function writeToModuleConfig(newData) {
   const { packageJson } = readPackageUpSync();
   const configPath = path.resolve(process.cwd(), 'build', packageJson.version, 'module-config.json');
   const config = fs.existsSync(configPath) ? JSON.parse(fs.readFileSync(configPath, 'utf8')) : {};
+
   fs.writeFileSync(configPath, JSON.stringify({
     ...config,
     ...newData,
-  }, null, 2));
+  }));
 }