Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify ubuntu snp guest launch to generalize this across various linux distros #26

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

LakshmiSaiHarika
Copy link
Contributor

Built on branch pointing to PR #24

Updated to standardize the Ubuntu SNP setup and launch guest process to easily add support for the guest seed image creation, setup and launch SNP guest on on non-debian linux distros.

@LakshmiSaiHarika LakshmiSaiHarika force-pushed the standarize-ubuntu-snp-guest-launch branch from e0d17d1 to 141245c Compare December 14, 2024 04:00
Copy link
Contributor

@DGonzalezVillal DGonzalezVillal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just consider the comments I made on the other PR.
This could have all been the same PR IMO.

@LakshmiSaiHarika
Copy link
Contributor Author

LakshmiSaiHarika commented Dec 16, 2024

Acutally, the other PR is for optimizing the guest creation process only, and I thought this could be helpful in case to to apply these commits in the coco branch without standardizing upstream ubuntu guest creation process

… a separate SNP guest

This supports launch of various SNP Guests at the same time using unique guest name and guest qemu port.

A separate SNP guest can be launched with the --guest-name and --guest-port command option as follows:
  ./snp.sh launch-guest --guest-name <user-guest-name> --guest-port <user-guest-port>

Signed-off-by: Harika Nittala <[email protected]>
Updated to show the correct details for the guest SSH access.

Signed-off-by: Harika Nittala <[email protected]>
…tion process

Updated the ubuntu guest download process to download it once and re-use the same image to quickly create multiple guests with the improved performance.
Update of the  guest image download structure in ubuntu also helps to  easily add support for the same in the other OS linux distros.

Signed-off-by: Harika Nittala <[email protected]>
Modularized guest seed image creation in ubuntu to standardize this process across non-debian OS linux distros that has no support for cloud-localds utility supported in canonical distribution.

Signed-off-by: Harika Nittala <[email protected]>
@LakshmiSaiHarika LakshmiSaiHarika force-pushed the standarize-ubuntu-snp-guest-launch branch from 141245c to 496b46a Compare December 19, 2024 23:03
@LakshmiSaiHarika
Copy link
Contributor Author

lgtm, just consider the comments I made on the other PR. This could have all been the same PR IMO.

  1. Addressed Diego's comments in the other PR (PR Optimize and create multiple SNP guests in the Ubuntu Host #24 )
  2. Updated this PR to address the PR Optimize and create multiple SNP guests in the Ubuntu Host #24 comments raised by Diego

Generalize a way to get and install SNP guest kernel package(AMDSEV build), generalize initrd pattern to make it match across different OS linux distros(initrd/initramfs), and set the default ubuntu guest kernel append parameter.

Signed-off-by: Harika Nittala <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants