Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed CONFIG GET to be sent to a random node #28

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

barshaul
Copy link

@barshaul barshaul commented Aug 28, 2023

Removed CONFIG GET from AllNodes request policy and AllSucceeded response policy. CONFIG GET will be sent to a random node.

@barshaul barshaul requested a review from nihohit August 28, 2023 09:37
@nihohit
Copy link

nihohit commented Aug 28, 2023

Instead of this PR, please just align the request/response policies with the commands tips. You can import redis-rs#887, or revert the change from nihohit@45dc902

Alternatively, better explain this change, because the PR's description doesn't match the code or the change - for example, "CONFIG GET, REWRITE and RESETSTAT don't have a response nor request policy." - they have both, in the repo, since Adan added them (IMO wrongly)

@barshaul
Copy link
Author

Instead of this PR, please just align the request/response policies with the commands tips. You can import redis-rs#887, or revert the change from 45dc902

Alternatively, better explain this change, because the PR's description doesn't match the code or the change - for example, "CONFIG GET, REWRITE and RESETSTAT don't have a response nor request policy." - they have both, in the repo, since Adan added them (IMO wrongly)

CONFIG GET, REWRITE and RESETSTAT don't have a response nor request policy in Redis's command tips, which means, in my understanding, we need to decide how to handle them.

It make sense to send all of them to all nodes, as it is suggested to CONFIG SET, and it make sense to apply AllSucceed response policy for RESETSTAT and REWRITE, which just return OKs.
re. Config GET the policy we did is AllNodes for request policy and we leaved it with Special response policy to return all answers.

Do you have a better solution?

…onse policy. CONFIG GET will be sent to a random node.
@barshaul barshaul changed the title Changed CONFIG GET response policy to SPECIAL Changed CONFIG GET to be sent to a random node Aug 30, 2023
@nihohit nihohit merged commit 6fee44c into amazon-contributing:main Aug 30, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants