Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not retry requests that have been dropped by the user. #189

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

nihohit
Copy link

@nihohit nihohit commented Sep 9, 2024

valkey-io/valkey-glide#2138

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@nihohit
Copy link
Author

nihohit commented Sep 9, 2024

@barshaul @avifenesh, please ping me when you have issues that are also relevant for upstream redis-rs - I'd be happy to contribute fixes, if I'm able to, and will be even happier to upstream your fixes :)

Copy link

@barshaul barshaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments.
Thanks a lot Shachar! 🌟 👑

redis/tests/test_cluster_async.rs Outdated Show resolved Hide resolved
redis/tests/test_cluster_async.rs Outdated Show resolved Hide resolved
@barshaul
Copy link

@barshaul @avifenesh, please ping me when you have issues that are also relevant for upstream redis-rs - I'd be happy to contribute fixes, if I'm able to, and will be even happier to upstream your fixes :)

Absolutely, will do! Thanks!

@nihohit
Copy link
Author

nihohit commented Sep 10, 2024

@barshaul done.

@barshaul barshaul merged commit c54a463 into amazon-contributing:main Sep 11, 2024
10 checks passed
@nihohit nihohit deleted the fix-retries-amz branch September 11, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants