Handle SPUBLISH as a non key-based command #182
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that SPUBLISH messages won’t be redirected to a random node if the intended target node isn’t available. The optimization of routing to a random node should only apply to commands that return a MOVED error if the target node isn’t the slot owner. The issue with SPUBLISH is that its behavior is unpredictable when redirected: if the randomly chosen node is outside the slot’s shard, a MOVED error will be returned; otherwise, the command might succeed, leading to inconsistent behavior. To address this, we will implement a PRIMARY_PREFERRED routing strategy for SPUBLISH, deliberately routing failed SPUBLISH commands to other nodes within the same shard.