added blocking commands tests #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikolomi
reviewed
Jul 4, 2024
There was a problem hiding this comment.
I dont think a single tests justifies having it in a new file, its better to keep them together in the test_cluster_async.rs
There was a problem hiding this comment.
To my understanding we are planing to create state restoration at some point, so i thought it is better to create a new file ready to add massive tests when we will have the support. can move back if you think its better.
avifenesh
force-pushed
the
test_blocking_commands
branch
from
20a2863
to
36094fd
Compare
ikolomi
requested changes
Jul 4, 2024
|
|
||
| use crate::support::*; | ||
| #[tokio::test] | ||
| async fn test_blocking_command_when_cluster_drops() { |
There was a problem hiding this comment.
why to invent a different logic and form - copy paste and modify:
redis-rs/redis/tests/test_cluster_async.rs
Line 3680 in 4571c91
avifenesh
force-pushed
the
test_blocking_commands
branch
from
36094fd
to
500baf2
Compare
avifenesh
force-pushed
the
test_blocking_commands
branch
2 times, most recently
from
7be1859
to
21619e6
Compare
avifenesh
force-pushed
the
test_blocking_commands
branch
from
21619e6
to
30350e6
Compare
ikolomi
approved these changes
Jul 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.