Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge fixes from upstream #165

Merged
merged 3 commits into from
Jun 27, 2024
Merged

Merge fixes from upstream #165

merged 3 commits into from
Jun 27, 2024

Conversation

barshaul
Copy link

@barshaul barshaul commented Jun 26, 2024 •
edited
Loading

Including:

  1. Handle errors even when out of retries. - Handle errors even when out of retries. redis-rs/redis-rs#1186
  2. Send retries in multi-node reconnect to new connection Send retries in multi-node reconnect to new connection. redis-rs/redis-rs#1202

@barshaul barshaul force-pushed the merge_from_new branch 4 times, most recently from e5c7d0c to 276864a Compare June 26, 2024 15:03
@nihohit @barshaul
Handle errors even when out of retries.
1207eb1 
Async cluster connections now can handle request
errors even when the request shouldn't retry.
Before this change, topology refreshes and
reconnects only happened on retries. This change
ensures that they will happen regardless of retries.
@nihohit @barshaul
Send retries in multi-node reconnect to new connection.
221c14a 
This fixes a situtation where a multi-node request is sent after a disconnect, and is repeatedly being sent to the old, disconnected connection.
This is caused by multi-node requests being routed with a specific connection, instead of looking for a new connection after a disconnect.

amazon-contributing#144
@barshaul barshaul marked this pull request as ready for review June 26, 2024 16:52
@barshaul barshaul changed the title Merge from upstream NEW Merge fixes from upstream Jun 26, 2024
@barshaul barshaul requested a review from ikolomi June 26, 2024 16:53
@barshaul barshaul mentioned this pull request Jun 26, 2024
Merged
@barshaul barshaul merged commit 5496098 into amazon-contributing:main Jun 27, 2024
10 checks passed
@barshaul barshaul mentioned this pull request Jun 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikolomi ikolomi ikolomi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@barshaul @ikolomi @nihohit