Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge from upstream #154

Closed
wants to merge 9 commits into from
Closed

Merge from upstream #154

wants to merge 9 commits into from

Conversation

barshaul
Copy link

@barshaul barshaul commented Jun 10, 2024 •
edited
Loading

Including:

  1. Handle errors even when out of retries. - Handle errors even when out of retries. redis-rs/redis-rs#1186
  2. Send retries in multi-node reconnect to new connection Send retries in multi-node reconnect to new connection. redis-rs/redis-rs#1202
  3. Add configuration for cluster tests.
  4. Catch panics from task::spawn in tests. (Catch panics from task::spawn in tests. redis-rs/redis-rs#1015)
  5. Update rustls + tokio-rustls + futures-rustls
  6. Wait for free port in legal range. Log the server / cluster logfile on error. redis-rs/redis-rs#1200
  7. Log the server / cluster logfile on error. Log the server / cluster logfile on error. redis-rs/redis-rs#1200

@barshaul barshaul mentioned this pull request Jun 10, 2024
Merged
@barshaul barshaul force-pushed the fix_multi_node_retry branch 3 times, most recently from af2b318 to 3cd6fe4 Compare June 10, 2024 13:43
@barshaul barshaul requested a review from avifenesh June 10, 2024 16:37
@avifenesh
Copy link
Member

Now after merging scan and pubsub it might have some breaking changes - please rebase over our repo and test, and check if changes needed.
Other than that LGTM.
But I'll advise to add @eifrah-aws as reviewer as well, he is the pro in rust.

@barshaul barshaul force-pushed the fix_multi_node_retry branch 3 times, most recently from 5c47d9b to 2088795 Compare June 26, 2024 11:38
@barshaul barshaul marked this pull request as draft June 26, 2024 12:54
nihohit and others added 8 commits June 26, 2024 15:03
@nihohit @barshaul
Send retries in multi-node reconnect to new connection.
e094b22 
This fixes a situtation where a multi-node request is sent after a disconnect, and is repeatedly being sent to the old, disconnected connection.
This is caused by multi-node requests being routed with a specific connection, instead of looking for a new connection after a disconnect.

amazon-contributing#144
@nihohit @barshaul
Add configuration for cluster tests.
950798a 
This makes it easy to add new variables to the tests without requiring large modifications.
@nihohit @barshaul
Handle errors even when out of retries.
b45ca56 
Async cluster connections now can handle request
errors even when the request shouldn't retry.
Before this change, topology refreshes and
reconnects only happened on retries. This change
ensures that they will happen regardless of retries.
@nihohit @barshaul
Update rustls + tokio-rustls + futures-rustls
0a47439
@nihohit @barshaul
Log the server / cluster logfile on error.
50991a1 
This allows us to find errors that aren't visible
in stdout/stderr.
@barshaul
Fix
bb33965
@barshaul
try to revoke cache
da4cbb0
@barshaul
Remove cache
4776cd7
@barshaul barshaul closed this Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avifenesh avifenesh Awaiting requested review from avifenesh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@barshaul @avifenesh @nihohit