Merge pull request #486 from seiyako/master

Resolve updateVoiceIdSpeakerId after _updateSpeakerIdInLcms resolves
amazon-connect · Oct 12, 2021 · fabb2df · fabb2df
2 parents f72c101 + 64764e5
commit fabb2df
Show file tree

Hide file tree

Showing 6 changed files with 42 additions and 9 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "amazon-connect-streams",
-  "version": "1.7.3",
+  "version": "1.7.4",
   "description": "Amazon Connect Streams Library",
   "engines": {
     "node": ">=12.0.0"

diff --git a/release/connect-streams-min.js b/release/connect-streams-min.js
diff --git a/release/connect-streams.js b/release/connect-streams.js
@@ -25591,8 +25591,13 @@ AWS.apiLoader.services['sts']['2011-06-15'] = require('../apis/sts-2011-06-15.mi
           }, {
             success: function (data) {
               connect.getLog().info("updateSpeakerIdInVoiceId succeeded").withObject(data).sendInternalLogToServer();
-              self._updateSpeakerIdInLcms(speakerId).catch(function(){});
-              resolve(data);
+              self._updateSpeakerIdInLcms(speakerId)
+                .then(function() {
+                  resolve(data);
+                })
+                .catch(function(err) {
+                  reject(err);
+                });
             },
             failure: function (err) {
               var error;
@@ -26087,7 +26092,7 @@ AWS.apiLoader.services['sts']['2011-06-15'] = require('../apis/sts-2011-06-15.mi
 
   connect.core = {};
   connect.core.initialized = false;
-  connect.version = "1.7.3";
+  connect.version = "1.7.4";
   connect.DEFAULT_BATCH_SIZE = 500;
 
   var CCP_SYN_TIMEOUT = 1000; // 1 sec

diff --git a/src/api.js b/src/api.js
@@ -1735,8 +1735,13 @@
           }, {
             success: function (data) {
               connect.getLog().info("updateSpeakerIdInVoiceId succeeded").withObject(data).sendInternalLogToServer();
-              self._updateSpeakerIdInLcms(speakerId).catch(function(){});
-              resolve(data);
+              self._updateSpeakerIdInLcms(speakerId)
+                .then(function() {
+                  resolve(data);
+                })
+                .catch(function(err) {
+                  reject(err);
+                });
             },
             failure: function (err) {
               var error;

diff --git a/test/unit/voiceid.spec.js b/test/unit/voiceid.spec.js
@@ -1153,7 +1153,7 @@ describe('VoiceId', () => {
       connect.core.getClient.restore();
     });
 
-    it('should get rejected when no speakerId without calling backend', async () => {
+    it('should get rejected without calling backend when no speakerId is passed in', async () => {
       const response = {
         data: 'fakeData'
       };
@@ -1198,6 +1198,29 @@ describe('VoiceId', () => {
       expect(error.type).to.equal(connect.VoiceIdErrorTypes.UPDATE_SPEAKER_ID_FAILED);
       connect.core.getClient.restore();
     });
+
+    it('should get rejected when _updateSpeakerIdInLcms api call fails', async () => {
+      const response = 'fakeData';
+      sinon.stub(connect.core, 'getClient').callsFake(() => ({
+        call: (endpoint, params, callbacks) => {
+          callbacks.success(response);
+        }
+      }));
+      const voiceId = new connect.VoiceId(contactId);
+      voiceId.checkConferenceCall = sinon.stub();
+      voiceId.getDomainId = sinon.stub().callsFake(() => Promise.resolve(domainId));
+      voiceId._updateSpeakerIdInLcms = sinon.stub().callsFake(() => Promise.reject({ type: connect.VoiceIdErrorTypes.UPDATE_SPEAKER_ID_IN_LCMS_FAILED }));
+
+      let obj, error;
+      try {
+        obj = await voiceId.updateSpeakerIdInVoiceId(speakerId);
+      } catch (e) {
+        error = e;
+      }
+      expect(obj).to.be.a('undefined');
+      expect(error.type).to.equal(connect.VoiceIdErrorTypes.UPDATE_SPEAKER_ID_IN_LCMS_FAILED);
+      connect.core.getClient.restore();
+    });
   });
 
   describe('syncSpeakerId', () => {