Replace ucol_safeClone with ucol_clone as former has been deprecated

Signed-off-by: Shard Gupta <[email protected]>
amazon-aurora · Mar 3, 2025 · fe05c4e · fe05c4e
1 parent 225dd78
commit fe05c4e
Show file tree

Hide file tree

Showing 22 changed files with 24 additions and 24 deletions.
diff --git a/.github/workflows/code-coverage.yml b/.github/workflows/code-coverage.yml
@@ -5,7 +5,7 @@ on:
 
 jobs:
   run-code-coverage-tests:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     env:
       INSTALL_DIR: psql
     steps:

diff --git a/.github/workflows/dotnet-tests.yml b/.github/workflows/dotnet-tests.yml
@@ -3,7 +3,7 @@ on: [workflow_call]
 
 jobs:
   run-babelfish-dotnet-tests:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
       - uses: actions/checkout@v2
         id: checkout

diff --git a/.github/workflows/isolation-tests.yml b/.github/workflows/isolation-tests.yml
@@ -4,7 +4,7 @@ on: [workflow_call]
 jobs:
   isolation-tests:
     name: Isolation-Tests
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
       - uses: actions/checkout@v2
         id: checkout

diff --git a/.github/workflows/jdbc-tests-db-collation.yml b/.github/workflows/jdbc-tests-db-collation.yml
@@ -6,7 +6,7 @@ jobs:
     env:
       INSTALL_DIR: psql
       DATABASE_COLLATION_NAME: bbf_unicode_cp1_ci_ai
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
       - uses: actions/checkout@v2
         id: checkout

diff --git a/.github/workflows/jdbc-tests-pgaudit-enable.yml b/.github/workflows/jdbc-tests-pgaudit-enable.yml
@@ -11,7 +11,7 @@ jobs:
 
     env:
       INSTALL_DIR: psql
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
       - uses: actions/checkout@v2
         id: checkout

diff --git a/.github/workflows/jdbc-tests-single-db-mode.yml b/.github/workflows/jdbc-tests-single-db-mode.yml
@@ -5,7 +5,7 @@ jobs:
   run-babelfish-jdbc-tests:
     env:
       INSTALL_DIR: psql
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
       - uses: actions/checkout@v2
         id: checkout

diff --git a/.github/workflows/jdbc-tests-with-non-default-server-collation.yml b/.github/workflows/jdbc-tests-with-non-default-server-collation.yml
@@ -7,7 +7,7 @@ jobs:
       INSTALL_DIR: psql
       SERVER_COLLATION_NAME: chinese_prc_ci_as
 
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
       - uses: actions/checkout@v2
         id: checkout

diff --git a/.github/workflows/jdbc-tests-with-parallel-query.yml b/.github/workflows/jdbc-tests-with-parallel-query.yml
@@ -5,7 +5,7 @@ jobs:
   run-babelfish-jdbc-tests-with-parallel-query-mode:
     env:
       INSTALL_DIR: psql
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
       - uses: actions/checkout@v2
         id: checkout

diff --git a/.github/workflows/jdbc-tests.yml b/.github/workflows/jdbc-tests.yml
@@ -5,7 +5,7 @@ jobs:
   run-babelfish-jdbc-tests:
     env:
       INSTALL_DIR: psql
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
       - uses: actions/checkout@v2
         id: checkout

diff --git a/.github/workflows/major-version-upgrade.yml b/.github/workflows/major-version-upgrade.yml
@@ -9,7 +9,7 @@ jobs:
       ENGINE_BRANCH_FROM: BABEL_2_X_DEV__PG_14_X
       EXTENSION_BRANCH_FROM: BABEL_2_X_DEV
 
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
       - uses: actions/checkout@v2
 

diff --git a/.github/workflows/manual_tags.yml b/.github/workflows/manual_tags.yml
@@ -18,7 +18,7 @@ on:
 
 jobs:
   create_tag:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
 
     steps:
       - uses: actions/checkout@v2

diff --git a/.github/workflows/minor-version-upgrade.yml b/.github/workflows/minor-version-upgrade.yml
@@ -9,7 +9,7 @@ jobs:
       INSTALL_DIR: psql
 
     name: Build and test
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
       - uses: actions/checkout@v2
 

diff --git a/.github/workflows/odbc-tests.yml b/.github/workflows/odbc-tests.yml
@@ -3,7 +3,7 @@ on: [workflow_call]
 
 jobs:
   run-babelfish-odbc-tests:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
       - uses: actions/checkout@v2
         id: checkout

diff --git a/.github/workflows/pg_dump-restore-test.yml b/.github/workflows/pg_dump-restore-test.yml
@@ -4,7 +4,7 @@ on: [push, pull_request]
 jobs:
   generate-dump-restore-tests:
     name: Generate Dump/Restore Tests
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     outputs:
       dump-restore-path-list: ${{ steps.generate-dump-restore-path.outputs.dump-restore-path-list }}
     steps:
@@ -32,7 +32,7 @@ jobs:
       matrix:
         upgrade-path: ${{ fromJson(needs.generate-dump-restore-tests.outputs.dump-restore-path-list) }}
     name: Dump Restore Test using ${{ matrix.upgrade-path.dump_method }} for ${{ matrix.upgrade-path.title }} - format=${{ matrix.upgrade-path.dump_format }} - type=${{ matrix.upgrade-path.type }}
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
       - uses: actions/checkout@v2
 

diff --git a/.github/workflows/pr-code-coverage.yml b/.github/workflows/pr-code-coverage.yml
@@ -25,7 +25,7 @@ jobs:
 
   run-babelfish-code-coverage-for-pull_request:
     needs: [run-jdbc-tests, run-odbc-tests, run-dotnet-tests, run-python-tests, run-isolation-tests]
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
 
     - uses: actions/checkout@v2

diff --git a/.github/workflows/python-tests.yml b/.github/workflows/python-tests.yml
@@ -3,7 +3,7 @@ on: [workflow_call]
 
 jobs:
   run-babelfish-python-tests:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
       - uses: actions/checkout@v2
         id: checkout

diff --git a/.github/workflows/singledb-version-upgrade.yml b/.github/workflows/singledb-version-upgrade.yml
@@ -10,7 +10,7 @@ jobs:
       ENGINE_BRANCH_FROM: BABEL_2_X_DEV__PG_14_X
       EXTENSION_BRANCH_FROM: BABEL_2_X_DEV
 
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
       - uses: actions/checkout@v2
 

diff --git a/.github/workflows/sql-validation-tests.yml b/.github/workflows/sql-validation-tests.yml
@@ -3,7 +3,7 @@ on: [push, pull_request]
 
 jobs:
   run-sql-validation-tests:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
       - uses: actions/checkout@v2
         id: checkout

diff --git a/.github/workflows/tap-tests.yml b/.github/workflows/tap-tests.yml
@@ -11,7 +11,7 @@ jobs:
       INSTALL_DIR_16: psql16
       ENGINE_BRANCH_16: BABEL_4_X_DEV__PG_16_X
 
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
       - uses: actions/checkout@v2
         id: checkout

diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml
@@ -5,7 +5,7 @@ jobs:
   run-babelfish-unit-tests:
     env:
       INSTALL_DIR: psql
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
       - uses: actions/checkout@v2
         id: checkout

diff --git a/.github/workflows/upgrade-test.yml b/.github/workflows/upgrade-test.yml
@@ -4,7 +4,7 @@ on: [push, pull_request]
 jobs:
   generate-version-upgrade-tests:
     name: Generate Version Upgrade Tests
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     outputs:
       upgrade-path-list: ${{ steps.generate-upgrade-path.outputs.upgrade-path-list }}
     steps:
@@ -25,7 +25,7 @@ jobs:
       matrix:
         upgrade-path: ${{ fromJson(needs.generate-version-upgrade-tests.outputs.upgrade-path-list) }}
     name: Run Version Upgrade Test for ${{ matrix.upgrade-path.title }}
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
       - uses: actions/checkout@v2
 

diff --git a/contrib/babelfishpg_tsql/src/collation.c b/contrib/babelfishpg_tsql/src/collation.c
@@ -1485,7 +1485,7 @@ icu_compare_utf8_coll(UCollator  *coll, UChar *uchar1, int32_t ulen1,
 
 	if (is_cs_ai_range_cmp)
 	{
-		collator = ucol_safeClone(coll, NULL, NULL, &status);
+		collator = ucol_clone(coll, &status);
 
 		if (U_FAILURE(status))
 			ereport(ERROR,