Add null check for func args in tsql_get_expr (babelfish-for-postgres…

…ql#3527) The function get_rule_expr inside of sys.tsql_get_expr crashes when the param is null. Adding null check for the input parameters. Task: BABEL-5460 Signed-off-by: Sharath BP <[email protected]>
amazon-aurora · Feb 28, 2025 · 1676b52 · 1676b52
1 parent 0a03c22
commit 1676b52
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 3 deletions.
diff --git a/contrib/babelfishpg_tsql/src/pltsql_ruleutils.c b/contrib/babelfishpg_tsql/src/pltsql_ruleutils.c
@@ -398,11 +398,16 @@ PG_FUNCTION_INFO_V1(tsql_get_expr);
 Datum
 tsql_get_expr(PG_FUNCTION_ARGS)
 {
-	text	   *expr = PG_GETARG_TEXT_PP(0);
-	Oid			relid = PG_GETARG_OID(1);
+	text	   *expr;
+	Oid			relid;
 	int			prettyFlags;
 	char	   *relname;
-
+
+	if (PG_ARGISNULL(0) || PG_ARGISNULL(1))
+		PG_RETURN_NULL();
+
+	expr = PG_GETARG_TEXT_PP(0);
+	relid = PG_GETARG_OID(1);
 	prettyFlags = PRETTYFLAG_INDENT;
 
 	if (OidIsValid(relid))

diff --git a/test/JDBC/expected/sys-computed_columns-vu-verify.out b/test/JDBC/expected/sys-computed_columns-vu-verify.out
@@ -56,3 +56,11 @@ text
 <NULL>
 ~~END~~
 
+
+Select sys.tsql_get_expr(null, null)
+GO
+~~START~~
+text
+<NULL>
+~~END~~
+
diff --git a/test/JDBC/input/views/sys-computed_columns-vu-verify.sql b/test/JDBC/input/views/sys-computed_columns-vu-verify.sql
@@ -20,4 +20,7 @@ Select sys.tsql_get_expr('abc',123)
 GO
 
 Select sys.tsql_get_expr('abc',0)
+GO
+
+Select sys.tsql_get_expr(null, null)
 GO
-Original file line number
+Diff line change
@@ Expand Up / @@ -56,3 +56,11 @@ text @@
     <NULL>
     ~~END~~
+    Select sys.tsql_get_expr(null, null)
+    GO
+    ~~START~~
+    text
+    <NULL>
+    ~~END~~