This repository has been archived by the owner on Jun 5, 2018. It is now read-only.
Fix deleteDNSRecord #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santigimeno
force-pushed
the
fix_agent
branch
from
1673773
to
bbc4ac6
Compare
Make sure only the desired record is deleted taking into account that the `Start*` params only assure that `ListResourceRecordSets()` returns the records whose attributes are lexicographically equal or greater than the corresponding `Start*` params in asceding order. Improve the logging in this method.
santigimeno
force-pushed
the
fix_agent
branch
from
bbc4ac6
to
500e179
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure only the desired record is deleted taking into account that
the
Start*params only assure thatListResourceRecordSets()returnsthe records whose attributes are lexicographically equal or greater than the
corresponding
Start*params in ascending order.Improve the logging in this method.