Add InvalidTransition exception with more helpful message.
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
This is great! It seems to solves the only task in the TODO section. I'm currently rescuing from RuntimeError with minimal details about what's going on and this would be very helpful. I wonder why it has not been merged yet. Does this implementation need some work? Is it just a matter of resolving conflicts? I would love to contribute but I'm not sure how. |
You could start with resolving the conflicts and making sure the tests still pass. 😄 |
|
Updated to v0.7.0. Resolved conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought it would be nice to see and have access to a bit more information when the transition is invalid. This changes the
RuntimeErrorto a customStatefulEnum::InvalidTransitionexception. The error message contains the state and the event that was attempted. Those 2 pieces of information are also stored on the exception itself for easy access.I almost took it a step further by adding what the state would have been if the event had succeeded – e.g. in the test below:
Invalid transition from "resolved" to "assigned" via event :assign!'– but that would take significantly more work. I believe the solution to that would require storing the events in memory. I'm not even sure how useful it would be to know that information. But if you like the idea, I would be happy to continue to explore the idea.