Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Master #91

Open
wants to merge 3,699 commits into
base: master
Choose a base branch
from
Open

Master #91

wants to merge 3,699 commits into from

Conversation

nimbooce
Copy link

No description provided.

Marco Sanchez and others added 30 commits November 3, 2016 10:55
FBR-543 deleting 2 lines of testing
3aabf25
FBR-543 changing margins to 3 options, small, medium and large, also …
9fafc85 
…the xml and remplace the maximum value on each margin
FBR-547- change Margins options to Text sub-menu
b3fc9e8
FBR-544 Added a circle on color preference, displaying the current co…
da1add5 
…lor of the option, also added the asset for it
FBR-541Adding icons to action menu
d112fe4
FBR-546 added Header and Back Arrow to Settings Menu
8fa5e48
FBR-529 deleting comments
1897f39
FBR-546 added sub_settings.xml to handle toolbar functionality on sub…
18f0e15 
… preference screens, also added the functionality
FBR-546 Adding functionality to action menu items
04115be
Merge branch 'feature/FBR-540--Replace_Search_icons_with_Materials_st…
74301b1 
…yle_icons' into feature/FBR-543--Implement_Margins_menu
FBR-529- remove none used commented code
453771a
@nimbooce
Merge pull request #194 from benetech/feature/FBR-529--Change_gradle_…
b2e45fe 
…to_build_2_Flavors

Feature/fbr 529  change gradle to build 2 flavors
Merge branch 'master' into feature/FBR-524--Complete_the_Go_Read_UI_c…
a404265 
…hanges
FBR-524 deleting using instanceOf, create a abstract method to setupA…
72b6c9b 
…ctionBar on screens that it’s needed
new class to contains creation of the action bar menu
2f87a70
changing extended class
0a96b92
manually reverting previous change on the action bar for bookshare_menu
70951a0
Refactor pull up methods and variables
b3ecc9f
delete character
4ae082b
manual refactor deleting methods and variables no needed on bookshare…
d5bcbea 
…_menu
optimize imports
cc617f1
changing comment description for the class
56b8827
FBR-546 create handler for action bar activities. Handler can we use …
47a58f4 
…by other activities
FBR-546 clean up tabbing
a52a843
FBR-546 cleaning unused code
9d494c3
FBR-546 creating onCreateMenuOptionsWithoutPlugins for PreferenceActi…
ac3e1b1 
…vity
FBR-546 clean up commented code
34a6234
FBR-546 propagating return value to callers
d2349bd
FBR-546 clean up adding space line between returns
7da8139
FBR-546 clean up adding space line between returns
a11879a
@nimbooce
FBR-620: Fixed Repaint issue on correct object
c1e08b3 
Cached view would become disconnected during pause and not reconnected
after resume was called.   Repaint would happen on disconnected view
and the visible view would never update.
@nimbooce
Incremented version code
4b89e78
@nimbooce
Updated GoRead User Guide to 5.4
ae689e6
@nimbooce
FBR-625: no longer toggling header footer during every repaint.
9cd1d41
@nimbooce
Refactor extract method
9545bd1
@nimbooce
Wrapping entire call with try catch.
9d94767
@nimbooce
No longer logging exception, but throwing it, since caller catches.
a1845d8
@nimbooce
Should not call isLanguageAvailable with null book locale. Method wil…
ab06cab 
…l throw null pointer.
@nimbooce
Refactor extract method
2cb2cfd
@nimbooce
Removed method parameter
782cf10
@nimbooce
Removed multiple if condition and returning if locale is null
ec267a5
@nimbooce
Inverted null test and return if myTTS is null
59318b9
@nimbooce
inverted if to return if language is not available.
11529d8
@nimbooce
If book language is null or model is not ready, return null
161f3fe
@nimbooce
Refactor extract method
c186606
@nimbooce
Removed incorrect comment and fixed method name
78a7c4c
@nimbooce
Inverted method condition and caller
88e4b71
@nimbooce
Incremented version code
c61f7b5
@nimbooce
Updated User guide
5fe8d41
@nimbooce
Cleanly handing null value returned by gATD
d0080d9
@nimbooce
Incremented version code
2624d68
@nimbooce
Inverted logic to be clearer.
2e5bb1e
@nimbooce
Updated user guide
ac52add
@nimbooce
Incremented version code
86f0caf
@nimbooce
Changed version name and incremented version code
3937077
@nimbooce
Checking if model has been updated first, before asking it questions
07a4440
@nimbooce
FBR-634: Fixed classicist exception. Added .so files for x86.
d164a36
@nimbooce
Incremented version code
d91e82e
@nimbooce
FBR-635, The new addView with insert index seems to have changed beha…
4b69b7b 
…vior.

Added workaround to use default behavior vs. positioning toolbar always
at 0th index.
@nimbooce
Incremented version code
dbce131
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nimbooce @miguel-villalobos