Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Translations for Punjabi Language #684

Merged
merged 4 commits into from
Feb 27, 2021
Merged

Conversation

shivamsawlani02
Copy link
Contributor

@chirag-jn
I have added Punjabi Language. Please review these changes.

#548

@chirag-jn chirag-jn added the ui/ux User Interface & User Experience Issues/Improvements label Nov 5, 2020
<string name="message_error_connection">ਕੁਨੈਕਸ਼ਨ ਗਲਤੀ</string>
<string name="message_tap_to_retry">ਦੁਬਾਰਾ ਕੋਸ਼ਿਸ਼ ਕਰਨ ਲਈ ਟੈਪ ਕਰੋ</string>
<string name="message_error_video">ਵੀਡੀਓ ਚਲਾਉਣ ਦੌਰਾਨ ਗਲਤੀ</string>
<string name="message_error_amahi_anywhere_app">Amahi Anywhere ਤੁਹਾਡੇ ਸਰਵਰ ਵਿੱਚ ਐਪ ਪਹੁੰਚਯੋਗ ਨਹੀਂ ਹੈ. ਕਿਰਪਾ ਕਰਕੇ ਇਹ ਸੁਨਿਸ਼ਚਿਤ ਕਰੋ ਕਿ ਤੁਹਾਡੇ ਨੈਟਵਰਕ ਵਿੱਚ Amahi Anywhere ਐਪ ਸਥਾਪਿਤ, ਚੱਲ ਰਹੀ ਅਤੇ ਪਹੁੰਚਯੋਗ ਹੈ.</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

English inside a string. We are translating Amahi at other places too. Please correct this.


<string name="share_subject">ਮੇਰੇ Amahi ਘਰ ਦੇ ਸਰਵਰ ਦੀ ਜਾਂਚ ਕਰੋ!</string>
<string name="share_message">ਮੈਂ ਆਪਣੀਆਂ ਸਾਰੀਆਂ ਫਾਈਲਾਂ ਨੂੰ ਸਟੋਰ ਕਰਨ, ਬੈਕਅਪ ਲੈਣ ਅਤੇ ਸਟ੍ਰੀਮ ਕਰਨ ਲਈ Amahi ਹੋਮ ਸਰਵਰ ਦੀ ਵਰਤੋਂ ਕਰਦਾ ਹਾਂ.\n\nਇਸ ਦੀ ਜਾਂਚ ਕਰੋ!\n\n<a href="https://www.amahi.org/">https://www.amahi.org/</a></string>
<string name="title_version_settings">ਐਂਡਰਾਇਡ ਲਈ Amahi</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

English inside a string.

@chirag-jn
Copy link
Member

Please add copyright to values-pa/strings.xml. Refer values/strings.xml for the format and text.

@shivamsawlani02
Copy link
Contributor Author

Ok.I will make these changes

@shivamsawlani02
Copy link
Contributor Author

@chirag-jn I have made the required changes. Please review them.

@shivamsawlani02
Copy link
Contributor Author

Hey @chirag-jn ! Can you please review this pull request and tell me changes(if any)?

Copy link
Contributor

@Prakhar-Agarwal-byte Prakhar-Agarwal-byte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shivamsawlani02 Your branch has conflicts with Amahi: beta branch, please resolve them.

@chirag-jn
Copy link
Member

Please rebase the branch so that the merge conflicts are resolved.

@shivamsawlani02
Copy link
Contributor Author

@chirag-jn I have resolved the merge conflicts. Please have a look now.

@chirag-jn
Copy link
Member

@shivamsawlani02 did you try it locally? Build should have failed locally in my opinion.

@@ -45,6 +45,8 @@
<string name="language_fr">ఫ్రెంచ్</string>
<string name="language_es">స్పానిష్</string>
<string name="language_bn">బెంగాలీ</string>
<string name="language_pa">పంజాబీ</string>
<string name="language_te">తెలుగు</string>
<string name="language_de">జర్మన్</string>
<string name="language_te">తెలుగు</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

language_te present twice.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved.

@shivamsawlani02
Copy link
Contributor Author

@shivamsawlani02 did you try it locally? Build should have failed locally in my opinion.

Yes I did that locally.

@cpg cpg merged commit 1ff932e into amahi:beta Feb 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/ux User Interface & User Experience Issues/Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants