Fix ESC selection when not all ESCs are available #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the issue described on discord where flashing wouldn't work when the ESC you have less than the expected number of ESCs connected and an offset exists between the
selectedEscInfoandescData.https://discord.com/channels/1029170737342316605/1218531833961123950/1315472000000462980
The solution here should improve on the one I posted to discord as it keeps the ESC number consistent with the numbers shown next to the buttons in the top right.
I tested this only by writing the default config and my testing setup is somewhat limited so extra testing wouldn't hurt. @tridge would you be able to check if it solves your issue?
At the same time, when writing the default config with the bootloader in master (v13) the bootloader seems to overwrite its revision number and so the compare was always failing. I fixed that by ignoring the bootloader revision byte in the compare.