Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DroneCAN support #36

Merged
merged 63 commits into from
Nov 9, 2024
Merged

Conversation

tridge
Copy link
Member

@tridge tridge commented Jul 17, 2024

This adds DroneCAN support to AM32 and enables it on the VIMDRONES_L431 ESC
image

Features working:

  • motors spinning
  • parameter save/load/erase
  • debug text messages
  • ESC status messages working
  • firmware update over DroneCAN
  • ArmingStatus working
  • node restart
  • bi-directional support
  • firmware signature checking in CAN bootloader: added DroneCAN bootloader support AM32-bootloader#21
  • need to switch L431 to using HSE crystal instead of HSI

Remaining issues:

  • cell count should be a separate parameter, detection can be unreliable

@tridge tridge marked this pull request as draft July 17, 2024 05:16
@tridge tridge force-pushed the pr-DroneCAN-support branch from 307521d to 1b324be Compare July 17, 2024 06:19
@ianrmurphy
Copy link

@tridge now we have a bootloader for the B-G431B-ESC1, it should be possible to rebase this support onto that ESC. Can you review that task? If not I will be able to take a look later in the week. Note, I would need to setup a DroneCAN environment first.I have a suitable FC and I think I have an SLCAN device somewhere, need to dig it out and give it a try.
Otherwise, is there a DBC file available for DroneCAN? If so I have other CAN tools ready to go.

@ianrmurphy
Copy link

Also, I have tonight run a motor using the ST MC Workbench FOC code, not AM32. Would be possible I think to extend that for DroneCAN support without much work.

@tridge tridge force-pushed the pr-DroneCAN-support branch from ec63204 to 2080584 Compare August 24, 2024 00:40
@tridge tridge changed the base branch from develop to main August 24, 2024 00:43
@tridge tridge marked this pull request as ready for review August 24, 2024 00:44
@tridge tridge changed the title Added DroneCAN support (WIP) Added DroneCAN support Aug 24, 2024
@tridge tridge force-pushed the pr-DroneCAN-support branch 11 times, most recently from fb19e0e to baa1fd1 Compare August 26, 2024 22:22
@tridge tridge force-pushed the pr-DroneCAN-support branch 3 times, most recently from 0378139 to b158759 Compare September 15, 2024 09:47
@tridge tridge force-pushed the pr-DroneCAN-support branch from b158759 to 6019706 Compare September 18, 2024 22:27
@tridge tridge force-pushed the pr-DroneCAN-support branch 3 times, most recently from 50281e7 to 271a965 Compare October 9, 2024 00:42
@tridge tridge force-pushed the pr-DroneCAN-support branch from 14ddde6 to 552bd97 Compare November 9, 2024 20:57
@AlkaMotors AlkaMotors merged commit 7384a73 into am32-firmware:main Nov 9, 2024
2 checks passed
@@ -0,0 +1,72 @@
/*

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this have to do with DroneCAN? This shouldn't live here, if anything it should be something that can be optionally used by any ESC protocol, this just doesn't make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants