-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port to udisks2 from fork IGP/pam_usb + minor fixes #34
base: master
Are you sure you want to change the base?
Conversation
…n more apropiate for certain OS distributions
some minor changes
port to udisks2
250000μs to 100000μs
More cleaning.
Change conf file location to match updated Makefile.
Switching to pam_usb.conf to match other pam module naming schemes.
Switching to pam_usb.conf to match other pam module naming schemes.
Switching to pam_usb.conf to match other pam module naming schemes.
Switching to pam_usb.conf to match other pam module naming schemes.
Switching to pam_usb.conf to match other pam module naming schemes.
Switching to pam_usb.conf to match other pam module naming schemes.
Switching to pam_usb.conf to match other pam module naming schemes.
conf.h not needed here
conf.h not needed here
conf.h not needed here
Clean .conf, old one moved to examples/pam_usb.conf.
MANS deinstall command was incorrect.
Please see #31 (comment) |
Hello @aluzzardi. Sorry for the late response. I must admit it has been quite some time since I used pam_usb. From the looks of it, my PR includes some of @igp's changes and a few of the style changes you requested in #31. I assume the issue with xscreensaver mentioned in #31 is still unresolved, but perhaps that could be fixed separately? Since it's been a while, I'll give this branch a try again and let you know if it still works with libudisks2. |
Incidentally, the README links to your pam_usb wiki no longer work. I can update them in this branch if you like. |
I can confirm this is still compiling and working properly for me using libudisks2 version 2.8.1-4. I had to move the |
Thanks a lot, @Danesprite. I see there's an open comment by @andrey-utkin -- any concerns in merging this, or good to go? |
Hello. As mentioned here, I think merging from @igp's fork would be good for porting pam_usb to udisks2, as a lot of the issues with @luka-n's PR are fixed. My fork also fixes a code style issue and adds an
AUTHORS
file. I'm not sure if any other contributors need to be listed there.