Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to udisks2 from fork IGP/pam_usb + minor fixes #34

Open
wants to merge 30 commits into
base: master
Choose a base branch
from

Conversation

drmfinlay
Copy link

Hello. As mentioned here, I think merging from @igp's fork would be good for porting pam_usb to udisks2, as a lot of the issues with @luka-n's PR are fixed. My fork also fixes a code style issue and adds an AUTHORS file. I'm not sure if any other contributors need to be listed there.

frantsao and others added 30 commits March 16, 2016 23:34
…n more apropiate for certain OS distributions
More cleaning.
Change conf file location to match updated Makefile.
Switching to pam_usb.conf to match other pam module naming schemes.
Switching to pam_usb.conf to match other pam module naming schemes.
Switching to pam_usb.conf to match other pam module naming schemes.
Switching to pam_usb.conf to match other pam module naming schemes.
Switching to pam_usb.conf to match other pam module naming schemes.
Switching to pam_usb.conf to match other pam module naming schemes.
Switching to pam_usb.conf to match other pam module naming schemes.
conf.h not needed here
conf.h not needed here
conf.h not needed here
Clean .conf, old one moved to examples/pam_usb.conf.
MANS deinstall command was incorrect.
@andrey-utkin
Copy link

Please see #31 (comment)

@aluzzardi
Copy link
Owner

@Danesprite @luka-n: I'm confused as to which PR to merge between this and #31

@drmfinlay
Copy link
Author

drmfinlay commented Apr 2, 2020

Hello @aluzzardi. Sorry for the late response.

I must admit it has been quite some time since I used pam_usb. From the looks of it, my PR includes some of @igp's changes and a few of the style changes you requested in #31. I assume the issue with xscreensaver mentioned in #31 is still unresolved, but perhaps that could be fixed separately?

Since it's been a while, I'll give this branch a try again and let you know if it still works with libudisks2.

@drmfinlay
Copy link
Author

Incidentally, the README links to your pam_usb wiki no longer work. I can update them in this branch if you like.

@drmfinlay
Copy link
Author

I can confirm this is still compiling and working properly for me using libudisks2 version 2.8.1-4. I had to move the pam_usb.so file from /lib64/security to /lib/x86_64-linux-gnu/security for it to work though. I guess the path for PAM module files has changed on newer distributions.

@aluzzardi
Copy link
Owner

Thanks a lot, @Danesprite.

I see there's an open comment by @andrey-utkin -- any concerns in merging this, or good to go?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants